Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result Pie Charts #15

Merged
merged 12 commits into from
Jun 27, 2022
Merged

Result Pie Charts #15

merged 12 commits into from
Jun 27, 2022

Conversation

dasGoogle
Copy link
Contributor

Displays pie charts for the voting results.
Merge #14 first, since this branch relies on these changes.

image

rgwohlbold
rgwohlbold approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@rgwohlbold rgwohlbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will not be as nice for longer answers (some lectures do have these). The colors are also not the easiest to discern, that could be changed at some point as well. The priority should be to get this merged before Wednesday so we can give a small Live-Demo :)

frontend/src/components/QuestionResults.tsx Outdated Show resolved Hide resolved
@dasGoogle
Copy link
Contributor Author

Looks good. This will not be as nice for longer answers (some lectures do have these). The colors are also not the easiest to discern, that could be changed at some point as well. The priority should be to get this merged before Wednesday so we can give a small Live-Demo :)

I have created issues #16 and #17 for this, when we have a look at this again.

@Greenscreen23
Copy link
Member

I'd like to review this one after #14 is merged, as it is easier to see the diff, or is there some way to this in github that I'm missing

@dasGoogle
Copy link
Contributor Author

dasGoogle commented Jun 27, 2022 •
edited
Loading

I'd like to review this one after #14 is merged, as it is easier to see the diff, or is there some way to this in github that I'm missing

I don't think so, however all changes made by me are in the following file: https://github.com/solid-polls/solid/blob/ba0fbbc57765b74685ab50e2da0be35d9742c65a/frontend/src/components/QuestionResults.tsx

Greenscreen23
Greenscreen23 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@Greenscreen23 Greenscreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's your only change, then I guess this looks fine :)

@dasGoogle dasGoogle merged commit 736d429 into main Jun 27, 2022
@dasGoogle dasGoogle deleted the feature/result-graphs branch June 27, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasrad02 lukasrad02 lukasrad02 approved these changes

@Greenscreen23 Greenscreen23 Greenscreen23 approved these changes

@rgwohlbold rgwohlbold rgwohlbold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasGoogle @Greenscreen23 @rgwohlbold @lukasrad02